Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Removed restangular from TenantService#3633

Merged
mitchell852 merged 3 commits intoapache:masterfrom
ocket8888:removing-restangular-TenantService
Jun 7, 2019
Merged

Removed restangular from TenantService#3633
mitchell852 merged 3 commits intoapache:masterfrom
ocket8888:removing-restangular-TenantService

Conversation

@ocket8888
Copy link
Copy Markdown
Contributor

@ocket8888 ocket8888 commented May 28, 2019

What does this PR (Pull Request) do?

Removes a dependency on Restangular from the "TenantService"

Which Traffic Control components are affected by this PR?

  • Traffic Portal

Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.

What is the best way to verify this PR?

No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.

Jeremy: actually, the only way to truly verify that the functionality did not change is to:

  1. run the UI tests (which is a very small subset of all TP functionality)
  2. manually verify the functionality associated with ALL the services functions that changed just to be sure all is well.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@dangogh dangogh added tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1 and removed tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1 labels May 28, 2019
@mitchell852 mitchell852 self-assigned this May 30, 2019
@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented May 31, 2019

UI tests pass

@mitchell852
Copy link
Copy Markdown
Member

mitchell852 commented May 31, 2019

retest this please

mitchell852
mitchell852 reviewed May 31, 2019
View reviewed changes
Comment thread traffic_portal/app/src/common/api/TenantService.js Outdated
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented May 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3771/
Test PASSed.

@ocket8888 ocket8888 force-pushed the removing-restangular-TenantService branch from ac29a4a to 7e766b8 Compare June 3, 2019 13:44
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 3, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3783/
Test PASSed.

mitchell852
mitchell852 suggested changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of changes required

Comment thread traffic_portal/app/src/common/api/TenantService.js Outdated
Comment thread traffic_portal/app/src/common/api/TenantService.js Outdated
@ocket8888 ocket8888 force-pushed the removing-restangular-TenantService branch from 7e766b8 to e244966 Compare June 4, 2019 17:08
mitchell852
mitchell852 suggested changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mitchell852 mitchell852 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards on a couple. looks like they were wrong in the original file.

Comment thread traffic_portal/app/src/common/api/TenantService.js Outdated
Comment thread traffic_portal/app/src/common/api/TenantService.js Outdated
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 4, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3816/
Test PASSed.

@ocket8888 ocket8888 force-pushed the removing-restangular-TenantService branch from e244966 to 0977c70 Compare June 4, 2019 17:30
@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 4, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3817/
Test FAILed.

@ocket8888
Copy link
Copy Markdown
Contributor Author

ocket8888 commented Jun 6, 2019

retest this please

@asfgit
Copy link
Copy Markdown
Contributor

asfgit commented Jun 6, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3834/
Test PASSed.

@mitchell852 mitchell852 merged commit f04bd4b into apache:master Jun 7, 2019
@ocket8888 ocket8888 deleted the removing-restangular-TenantService branch June 8, 2019 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mitchell852 mitchell852 mitchell852 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mitchell852 mitchell852

Labels

tech debt rework due to choosing easy/limited solution Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ocket8888 @mitchell852 @asfgit @dangogh